Add support for HTTP list parameters to request builder#8
Add support for HTTP list parameters to request builder#8awswim wants to merge 2 commits intoRightpoint:masterfrom
Conversation
There was a problem hiding this comment.
Can you add descriptions to the JavaDoc on these methods that explains the format that they are putting them in so that it's clear? Explain that it's using the KEY[]=... pattern so that it's explicit and clear.
|
I've never seen this format before, seems a bit strange to me, but we can support it if it's not impacting anything else. Is there a more "official" name for this? Or can we use something more descriptive? ListParams seems a little strange to me, but maybe array params or something? |
|
I called it MultipleValueParam, because the idea is that typically most parameters are 1:1 key:value pairs while these are 1:many key:value pairs. Let me know if you think it would be better as ArrayParam or ManyValueParam. |
2 participants
Technically it's not a HTTP standard, but many APIs accept a 1:many relationship in HTTP parameters so long as those parameters have
[]brackets.Example supporting multiple user IDs:
I'm adding support for those parameters to RequestBuilder.